feat: shared dispute game migration for interop#19840
Open
stevennevins wants to merge 34 commits intodevelopfrom
Open
feat: shared dispute game migration for interop#19840stevennevins wants to merge 34 commits intodevelopfrom
stevennevins wants to merge 34 commits intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #19840 +/- ##
===========================================
+ Coverage 75.8% 77.9% +2.0%
===========================================
Files 683 139 -544
Lines 72644 6843 -65801
===========================================
- Hits 55092 5331 -49761
+ Misses 17408 1512 -15896
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
stevennevins
force-pushed
the
feat/interop-shared-dispute-game
branch
from
6f4c1bd to
10808b1
Compare
…OptimismPortal2 via the feature flag
…ve interface from OPCM_V2
…rade ordering Bump OptimismPortal2.version() from 5.4.0 to 5.5.0 so OPCM_V2 can upgrade from OptimismPortalInterop (5.4.1+interop) without triggering the DowngradeNotAllowed check. In OPContractsManagerV2._apply(), set the ETH_LOCKBOX feature on SystemConfig before upgrading the portal. Unlike OptimismPortalInterop which blindly sets the ethLockbox, OptimismPortal2.initialize() calls _assertValidLockboxState() which requires the ETH_LOCKBOX feature flag and ethLockbox address to be consistent. Update superRootsActive tests to support both OPCM_V2 (gameType mock) and legacy (slot 63 manipulation) paths via _enableSuperRootBehavior helper.
…lInterop when OPCM_V2 and Interop feature flags enabled
…e portal migration functions
stevennevins
force-pushed
the
feat/interop-shared-dispute-game
branch
from
34ae54c to
8a0e690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move migrateToSuperRoots(), migrateLiquidity(), and 3 param initialize() from OptimismPortalInterop to OptimismPortal2.
And unify OPCM_V2 to target OptimismPortal2 for the Interop migration codepath
Tests
Tests the superchain system features are properly configured
Tests that migration succeeds with the system feature is enabled
Additional context
Part of #19699
Associated design doc: https://github.com/ethereum-optimism/design-docs/blob/main/protocol/proofs/shared-dispute-game-migration.md
Metadata
Closes #19708
Closes #19710
Closes #19011